Drop PHP 5.4, throw an exception if JSON encoding fails #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maknz
force-pushed
the
json-error
branch
6 times, most recently
from
a963854
to
f0ec298
Compare
|
Okay, seems 5.4 has some annoying inconsistencies with character encoding, that aren't present in 5.5 and above (as verified by Travis). So I'm inclined to drop 5.4 support. That means we do need to bump the major version to 2.0 when we next release master, but considering we want to introduce support for multiple teams, that'd likely be required anyway. |
maknz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27 and replaces #28.
If JSON encoding fails (for example, by bad character encoding), a
RuntimeExceptionwill be thrown with a descriptive message of the problem.